feat: harden filesystem edits and release controls - #26
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 922abb61f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| run: >- | ||
| gh release create "$GITHUB_REF_NAME" |
There was a problem hiding this comment.
In .github/workflows/release.yml, this job is triggered by any pushed v* tag and reaches gh release create without verifying that GITHUB_SHA is an ancestor of origin/main. If someone with tag-push rights tags an unmerged branch or local commit whose package version matches the tag, the workflow will still publish a GitHub release, bypassing the documented reviewed-main release path; add an explicit fetch/merge-base --is-ancestor check before creating the release.
Useful? React with 👍 / 👎.
| const pathStat = await fsLstat(filePath); | ||
| if (pathStat.isSymbolicLink()) { |
There was a problem hiding this comment.
When the parent directory can be modified concurrently, this lstat-then-open-by-path sequence still has a symlink race: an entry that was a regular file at lstat can be swapped for a symlink before the later fsOpen(filePath, 'r'), and read() will expose the symlink target despite the new symlink rejection guarantee. Use no-follow open semantics or validate the opened handle against the lstat result before decoding content.
Useful? React with 👍 / 👎.
2 participants
Summary
Frozen issues
Closes #18
Closes #19
Closes #20
Closes #21
Closes #22
Closes #23
Closes #24
Repository settings required by #22 and #23 will be applied and verified after merge.
Validation